uorb: add section on nested messages #3562
Conversation
|
@GuillaumeLaine You're going to hate me, but I just did a fairly significant restructure of the starting section on defining messages. This is to fix the fact that nested messages was "floating" and it wasn't clear to me the difference between messages and topics. The reason you'll hate me is that this will require a rebase of the other PR and a little restructure on that. Let me know what you think? Note, I wrote this late in the day. I'm pretty sure the structure is good, but there might be typos and grammar errors. |
There was a problem hiding this comment.
@hamishwillee I think the restructure makes a lot of sense, I'm happy to rebase the other PR once this one goes in 👍🏻
Co-authored-by: Guillaume Lainé <[email protected]>
| PositionSetpoint previous | ||
| PositionSetpoint current | ||
| PositionSetpoint next | ||
| ``` | ||
|
|
There was a problem hiding this comment.
@GuillaumeLaine A few lines below it says
The
listenercommand is only available on Pixracer (FMUv4) and Linux / OS X.
Is that still true? How can I check the supported boards?
There was a problem hiding this comment.
I don't know, I'm not even sure how to check. I think the CONFIG_SYSTEMCMDS_TOPIC_LISTENER=y board config enables the listener command, but I'm not sure.
If this is case, this config does seem enabled for most boards.
What I can tell is that the line you quoted was written in the docs earlier (4 years ago) than the listener board config was enabled in most boards (3 years ago). Seems possible that docs were not updated after the fact
There was a problem hiding this comment.
Nice forensics! Also interesting that the boards after fmuv4 are enabled, but the older ones aren't. I'm going to update this as though we were certain.
Co-authored-by: Hamish Willee <[email protected]>
There was a problem hiding this comment.
OK, I think this is good. Merging. Much appreciated @GuillaumeLaine
|
No flaws found |
Follow up to: #3465 (comment)